Review Request: Port from QAbstractItemModel::reset() to QAbstractItemModel::(begin|end)ResetModel().

Jon Severinsson jon at severinsson.net
Sun Oct 28 07:00:38 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106955/#review21020
-----------------------------------------------------------


Over a week and still no comments. If no one objects in the next few days, I'm simply gonna push this without any "Ship It!".

- Jon Severinsson


On Oct. 19, 2012, 7:54 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106955/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 7:54 p.m.)
> 
> 
> Review request for Phonon.
> 
> 
> Description
> -------
> 
> Port from QAbstractItemModel::reset() to QAbstractItemModel::(begin|end)ResetModel().
> 
> This is the recommended API in Qt >= 4.6, and the only API in Qt5.
> 
> 
> Diffs
> -----
> 
>   phonon/objectdescriptionmodel.cpp 97a8b5d 
>   phonon/objectdescriptionmodel_p.h 2200c8d 
> 
> Diff: http://git.reviewboard.kde.org/r/106955/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121028/3561a337/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list