Review Request: Update copy-n-paste code in FindPhononInternal.cmake with all changes in kdelibs frameworks branch

Jon Severinsson jon at severinsson.net
Sun Oct 28 07:01:05 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106971/#review21025
-----------------------------------------------------------


Over a week and still no comments. If no one objects in the next few days, I'm simply gonna push this without any "Ship It!".

- Jon Severinsson


On Oct. 20, 2012, 7:24 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106971/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 7:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> This is based on my "Phonon five merge and cleanup" and "Update copy-n-paste code in FindPhononInternal.cmake with all changes in kdelibs 4.10 branch" patches, and are required for Phonon five to build with Qt5.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake 20220a3 
> 
> Diff: http://git.reviewboard.kde.org/r/106971/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121028/447909ab/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


More information about the kde-multimedia mailing list