Review Request: Remove QFSFileEngine useage from Phonon five.

[Harald Sitter]

> On Oct. 21, 2012, 10:30 a.m., Harald Sitter wrote:
> > phonon/mediasource.cpp, line 58
> > <http://git.reviewboard.kde.org/r/106974/diff/2/?file=91573#file91573line58>
> >
> >     documentation on why path and url would be useful
> 
> Jon Severinsson wrote:
>     I thought it self explanatory, we need the ":/" syntax for QFile, and the "qrc://" syntax for QUrl.
>     
>     The old code would not work for "qrc://" URLs, and would create an invalid "file::/foo" QUrl for a ":/foo" file path (wich don't stop it from working, but provides garbage output to users).

It is apparent that the two have different syntax, not why.


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106974/#review20616
-----------------------------------------------------------


On Oct. 21, 2012, 9:59 a.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106974/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2012, 9:59 a.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> QFSFileEngine has been removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome.
> 
> 
> Diffs
> -----
> 
>   phonon/mediasource.cpp 9e35094 
> 
> Diff: http://git.reviewboard.kde.org/r/106974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121021/40fd4699/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel