Review Request: Remove QFSFileEngine useage from Phonon five.

[Jon Severinsson]

> On Oct. 21, 2012, 10:46 a.m., David Faure wrote:
> > Urgh, too much detailed magic.
> > 
> > Either the input string is always a local path, and use fromLocalFile. Or it's always a URL, and use QUrl(QString). Or it could be either one, and then QUrl::fromUserInput(QString) is what you're looking for.

Oh, it is uggly, but removing the ugglyness merely moves it to the user.

As for fromUserInput, QUrl::fromUserInput("foo") will result in "http://foo", while it supposed to be the file "foo" in cwd, so using it is a no-go.


- Jon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106974/#review20619
-----------------------------------------------------------


On Oct. 21, 2012, 9:59 a.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106974/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2012, 9:59 a.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> QFSFileEngine has been removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome.
> 
> 
> Diffs
> -----
> 
>   phonon/mediasource.cpp 9e35094 
> 
> Diff: http://git.reviewboard.kde.org/r/106974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121021/cd37bab4/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel