Review Request: Accessibility support for KMix

Christian Esken esken at kde.org
Sat Oct 13 11:51:05 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106584/#review20252
-----------------------------------------------------------

Ship it!


Looks good. Thanks for the contribution, José.
I will apply your patch manually, as applying to mdwslider.cpp was rejected due to my recent code changes in trunk.

- Christian Esken


On Oct. 10, 2012, 6:41 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106584/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2012, 6:41 p.m.)
> 
> 
> Review request for KDE Accessibility and KDE Multimedia.
> 
> 
> Description
> -------
> 
> Accessible names were given to:
>  - Volume sliders
>  - Widgets in "Configure channels..." dialog
>  - List of channels in master volume dialog
> 
> 
> Diffs
> -----
> 
>   gui/dialogselectmaster.cpp 592a44d 
>   gui/dialogviewconfiguration.cpp 44b0892 
>   gui/mdwslider.cpp bb3af65 
> 
> Diff: http://git.reviewboard.kde.org/r/106584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121013/302abd11/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list