Patch to re-enable vorbis-support in audiocd-kio

[Michael Pyne]

On Thursday, September 27, 2012 16:53:35 Felix Tiede wrote:
> Hello,
> 
> as per mpyne's request from https://bugs.kde.org/show_bug.cgi?id=307343#c4
> I propose my patch to audiocd-kio for review.

> I have removed all conditional compiling from
> the plugin in favor of this configure-time check as I doubt there is still
> an installation of libvorbisenc older than those ten years.

I think you've left this part of the patch out. ;)

> I am not sure which is the minimum version of cmake to create
> HAVE_LIBVORBISENC2 variable, my cmake is v2.8.9 and does so.

I've just checked and it seems that FindOggVorbis.cmake is actually part of 
kdelibs, not CMake. So we can be assured that a proper FindOggVorbis.cmake 
will be available.

Are there any issues with bumping the required version of libvorbis? Despite 
the name of the configure check I've been able to verify that just as Felix 
says, even very old releases of libvorbis provide the required interface.

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120930/c3a98551/attachment.sig>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia