Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106974/#review21368
-----------------------------------------------------------


This review has been submitted with commit 459c6a2c9b9f9dc42fde1a46031066f2b0f9fa6e by Jon Severinsson to branch five.

- Commit Hook


On Nov. 1, 2012, 1:48 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106974/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2012, 1:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> QFSFileEngine has been removed from Qt5, so the MediaSource(const QString &filename) constructor has to be reworked to not need it.  The only behaviourial changes from the original code are that non-local absolute file paths (eg smb share file paths such as "//hostname/share/path") and "qrc:///" URLs actually works.
> 
> I have also added qrc support to the QUrl constructor, and deprecated the QString constructor in favour of it.
> 
> 
> Diffs
> -----
> 
>   phonon/mediasource.h 5374f00 
>   phonon/mediasource.cpp 9e35094 
> 
> Diff: http://git.reviewboard.kde.org/r/106974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121103/1effc693/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel