Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

Jon Severinsson jon at
Thu Nov 1 13:48:19 GMT 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 1, 2012, 1:48 p.m.)

Review request for KDE Frameworks and Phonon.


Right you are, new try.


QFSFileEngine has been removed from Qt5, so the MediaSource(const QString &filename) constructor has to be reworked to not need it.  The only behaviourial changes from the original code are that non-local absolute file paths (eg smb share file paths such as "//hostname/share/path") and "qrc:///" URLs actually works.

I have also added qrc support to the QUrl constructor, and deprecated the QString constructor in favour of it.

Diffs (updated)

  phonon/mediasource.h 5374f00 
  phonon/mediasource.cpp 9e35094 




Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
Kde-frameworks-devel mailing list
Kde-frameworks-devel at

More information about the kde-multimedia mailing list