Review Request: Fix master channel selection via kmix main window issue and fix no global master found issue

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105422/#review16041
-----------------------------------------------------------


Thanks. The patch looks nearly fine now. Just add the bug id and review board id and a short comment in the source code (to take that into considertation for further chanages - in a year nobody will know why it had been added.).

- Christian Esken


On July 10, 2012, 10:34 p.m., phoenix firebrd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105422/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 10:34 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> This patch solves this bug https://bugs.kde.org/show_bug.cgi?id=290177
> It also solves a problem with the dock icon appearing blank due to the mixer not able to find any global master. The device id returns something like "alsa_output.pci-0000_04_00.0.analog-surround-51" for 5.1 and "alsa_output.pci-0000_04_00.0.analog-stereo" for analog stereo and hence the issue.
> 
> 
> This addresses bug 290177.
>     http://bugs.kde.org/show_bug.cgi?id=290177
> 
> 
> Diffs
> -----
> 
>   core/mixer.cpp 8001073 
>   gui/kmixerwidget.cpp a9738aa 
> 
> Diff: http://git.reviewboard.kde.org/r/105422/diff/
> 
> 
> Testing
> -------
> 
> Tested, able to select the master channel from the kmix main window and also the dock icon shows up correctly after changing the phonon soundcard profile example from analog stereo to analog 5.1
> 
> 
> Thanks,
> 
> phoenix firebrd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120717/41363202/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia