Review Request: Kmix Dock menu entry to open phonon settings

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105449/#review15493
-----------------------------------------------------------


The patch itself looks fine. The only problem is, that I want to get rid of that menu, and not add extra functionality. That menu does not have any functionality that either the volume popup (or if that is disabled the main menu) has.
  - Mute
  - Restore
  - Select master channel (I have planned to move it in the popup as some kind of "Sound setup" button)

It is also important for cross-desktop compatibilty, for systems that only have one kind of "Activate Tray", like Unity.

See http://kmix5.wordpress.com/2012/06/26/kmixs-top-secret-features-part-1-volume-presets/ for the direction the Tray control is taking.



- Christian Esken


On July 6, 2012, 1:08 p.m., phoenix firebrd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105449/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 1:08 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> Added dock menu entry to open phonon settings
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=226124.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=226124
> 
> 
> Diffs
> -----
> 
>   gui/kmixdockwidget.cpp b438173 
> 
> Diff: http://git.reviewboard.kde.org/r/105449/diff/
> 
> 
> Testing
> -------
> 
> Testing done, on clicking the menu entry the phonon settings is opened.
> 
> 
> Thanks,
> 
> phoenix firebrd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120707/8ad9a999/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia