Review Request: Fix master channel selection via kmix main window issue and fix no global master found issue

[phoenix firebrd]

> On July 3, 2012, 9:20 p.m., Christian Esken wrote:
> > - Fallback to firstDevice sounds like a good idea
> > 
> > But I do not yet understand why it is important to create DialogSelectMaster only once? What problem does that solve, and how?
> > 
> > Also - I just tried to reproduce the issue and wasn't able to do so. It already works without the patch, but I know that the issue was present. Any idea how to reproduce it in the current version?

The idea of creating Dialogselectmaster only once is my mistake. The issue in the bug report id=290177 is, the docking is not updated after selecting the master channel via the kmix main window, this happens also in the case of changing the device profile in phonon and hence the blank icon. This is solved by updating the docking inside the function void KMixerWidget::controlsReconfiguredToplevel. I forgot to add this to the diff. I will update with a new diff with the stated changes if its ok.


- phoenix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105422/#review15350
-----------------------------------------------------------


On July 3, 2012, 8:11 a.m., phoenix firebrd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105422/
> -----------------------------------------------------------
> 
> (Updated July 3, 2012, 8:11 a.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> This patch solves this bug https://bugs.kde.org/show_bug.cgi?id=290177
> It also solves a problem with the dock icon appearing blank due to the mixer not able to find any global master. The device id returns something like "alsa_output.pci-0000_04_00.0.analog-surround-51" for 5.1 and "alsa_output.pci-0000_04_00.0.analog-stereo" for analog stereo and hence the issue.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=290177.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290177
> 
> 
> Diffs
> -----
> 
>   apps/kmix.cpp a7cd0a6 
>   core/mixer.cpp 8001073 
>   apps/kmix.h c088eac 
>   gui/dialogselectmaster.h b79b56a 
>   gui/dialogselectmaster.cpp a5e5f45 
> 
> Diff: http://git.reviewboard.kde.org/r/105422/diff/
> 
> 
> Testing
> -------
> 
> Tested, able to select the master channel from the kmix main window and also the dock icon shows up correctly after changing the phonon soundcard profile example from analog stereo to analog 5.1
> 
> 
> Thanks,
> 
> phoenix firebrd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120704/37e3b42f/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia