[PATCH] mplayerthumbs: Fix phonon support

[Anssi Hannula]

28.02.2012 08:52, Anssi Hannula kirjoitti:
> 28.02.2012 02:33, Christian Esken kirjoitti:
>> Am Freitag, 17. Februar 2012, 19:43:52 schrieb Anssi Hannula:
>>> On 05.02.2012 16:53, Anssi Hannula wrote:
>>>> Hi!
>>>>
>>>> The attached patch makes mplayerthumbs Phonon support work properly for
>>>> me. It mostly makes PhononBackend::readStreamInformation() wait a bit if
>>>> needed. Also, setTotalTime() signal connection is fixed (not 100% sure
>>>> if that connection is actually needed, though - didn't remove it for now).
>>>>
>>>> Tested with phonon 4.6.0 and phonon-gstreamer git master with  my
>>>> snapshot() support patch applied:
>>>> https://git.reviewboard.kde.org/r/103872/
>>>
>>> Ping for the previously attached kdemultimedia patch and the above
>>> phonon-gstreamer patch...
>>
>> Hello Anssi,
> 
> Hi.
> 
>> I am not entirely sure, but it looks a lot like mplayerthumbs is not 
>> maintained anymore. Also in the thread about KDE Multimedia SVN cleanup 
>> (http://lists.kde.org/?t=133002299600002&r=1&w=2) the maintainer didn't step 
>> up. I don't know if it is deprecated, but I would advise you to try to contact 
>> the original maintainer via personal Email.
> 
> OK, will try that, thanks. What about the above phonon-gstreamer patch
> that has been in the reviewboard for 3 weeks without reply? Or is such a
> delay normal and it will be eventually looked at?

Apparently the review had gone unnoticed, but mga phonon maintainer
(Colin Guthrie) directed me to #kde-multimedia and tdfischer reviewed
and applied it :)

Just noting it for the record, as this is slightly off-subject (the
patch of this thread is still unreviewed, I sent a query regarding that
to the original mplayerthumbs author earlier today).

>> If you also cannot reach him via Email there is probably nobody around who is 
>> proficient with that source code, and I would say it is OK to commit then 
>> without review.
> 
> I don't have commit access, though, but I guess someone else can commit
> it if I can't reach him...
> 


-- 
Anssi Hannula