[PATCH] mplayerthumbs: Fix phonon support

Anssi Hannula anssi.hannula at iki.fi
Sun Feb 5 14:53:46 GMT 2012


The attached patch makes mplayerthumbs Phonon support work properly for
me. It mostly makes PhononBackend::readStreamInformation() wait a bit if
needed. Also, setTotalTime() signal connection is fixed (not 100% sure
if that connection is actually needed, though - didn't remove it for now).

Tested with phonon 4.6.0 and phonon-gstreamer git master with  my
snapshot() support patch applied:

Also I have applied an upstreamed gst-plugins-base fix (
https://bugzilla.gnome.org/show_bug.cgi?id=668097 ) but I think that bug
might only have affected phonon-gstreamer 4.5.1 (git master doesn't use
subtitleoverlay element directly).

BTW, I find a bit interesting that there is 'mplayerthumbs' which has
MPlayer and Phonon support, and 'ffmpegthumbs' which supports FFmpeg.
Shouldn't they either get all unified, all separated, or one of them
(plus 'mplayerthumbs' has a curious name, shouldn't it be renamed?)

Anssi Hannula
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdemultimedia-mplayerthumbs-fix-phonon-support.patch
Type: text/x-patch
Size: 4753 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120205/29020371/attachment.bin>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at kde.org

More information about the kde-multimedia mailing list