[PATCH] juk: fix the disproportional expansion of a changed column

Γιώργος Κυλάφας (Giorgos Kylafas) gekylafas at gmail.com
Mon May 23 01:36:01 BST 2011

2011/5/7 Michael Pyne <mpyne at kde.org>:
> On Saturday, May 07, 2011 16:22:52 Γιώργος Κυλάφας wrote:
>> While checking Playlist::calculateColumnWeights(), I noticed that the
>> *all* the column weights were *always* reset to -1, but only the
>> weight of the changed one was re-calculated afterwards. So, I added
>> the line shown in the attached patch, which keeps the old column
>> weights and seems to fix the behavior I noticed.
> Good idea. As with caching in general it is essential to ensure that every way
> that column widths could be changed is accounted for and the cache cleared if
> necessary. In this case as long as column weights were cached correctly before
> your change should simply make it work again, but it's a good thing to keep in
> mind.
> [...]
> why don't you commit this patch and we'll
> test it out for a week or two? I think it's fine the way it is.

So far, I have not seen any problems with the above fix. Should we
backport it to the 4.6 branch?

In case we should, I created the attached patch. It only contains the
fix about marking a weight as dirty from 1230441, plus the caching of
weights from 1230877.


Γιώργος Κυλάφας (Giorgos Kylafas)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stable-update-column-widths.patch
Type: text/x-diff
Size: 1488 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110523/e6060f96/attachment.patch>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at kde.org

More information about the kde-multimedia mailing list