[PATCH] juk: save & restore playlist and tag editor sizes.

Michael Pyne mpyne at kde.org
Mon May 9 22:43:30 BST 2011

On Monday, May 09, 2011 12:43:20 Γιώργος Κυλάφας wrote:
> 2011/5/7 Michael Pyne <mpyne at kde.org>:
> > Either way the patch should be fine to commit once you've figured out
> > which looks more suitable (it's just that we don't all run the same
> > resolution screens so I try to avoid fixed default sizes where I can ;)
> Well, PlaylistSplitter's default sizes are 100/640, which I guessed
> were derived from line "resize(750, 500)" in JuK::setupLayout(). i.e.
> 100 + 640 = 750 - 10. So, I used the same reasoning (250 + 240 = 500 -
> 10) for the m_editorSplitter as well. :-)
> I tried not calling setSizes() if no sizes are saved, however the tag
> editor would get very large compared to the playlist.

OK, in that case I guess I have no objection to either your original or the 
updated patch. In fact your original might be better if the "hardcoded" values 
are hints instead of pixels to give the playlist items a bit more room than 
the tag editor. But either way should be acceptable.

 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110509/ed57b8b1/attachment.sig>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at kde.org

More information about the kde-multimedia mailing list