[PATCH] juk: save & restore playlist and tag editor sizes.

Michael Pyne mpyne at kde.org
Sat May 7 16:21:48 BST 2011

On Saturday, May 07, 2011 01:10:31 Γιώργος Κυλάφας wrote:
> Hi all,
> the full motivation behind my proposed fix about the storing of
> TagEditor's configuration on exit [1] was to show or not the TagEditor
> *and* use the same size as the previous execution of JuK. However, the
> latter was not supported, so I set out to implement it.
> I eventually came up with the attached patch. It follows the logic of
> saving/restoring the PlaylistSplitter's size, applied to
> "editorSplitter".
> I am not sure this is the proper/simpler/etc. way to accomplish this,
> so I would appreciate your comments. :-)

The patch works and is the right method.

I'm not sure why you set sizes of 250/240 if no sizes were already saved 
though, doesn't the size hint for the tag editor give it a good default size? 
If so you wouldn't need to do anything special if there is no saved sized 
other than to not call m_editorSplitter->setSizes().

Either way the patch should be fine to commit once you've figured out which 
looks more suitable (it's just that we don't all run the same resolution 
screens so I try to avoid fixed default sizes where I can ;)

 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110507/fbe65686/attachment.sig>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at kde.org

More information about the kde-multimedia mailing list