KDE/kdemultimedia/kscd

[Christian Esken]

Am Samstag, 8. Januar 2011, 23:03:15 schrieb Michael Jansen:
> SVN commit 1212979 by mjansen:
> 
> I had a crash here with kscd beeing unable to handle a disc i inserted into
> my drive (It is not the only one). Now it crashes no more. Doesn't work
> for me but it is better.
> 
> Christian: i cced you because you seem to be the last one working on kscd.

Hello Michael,

I cannot remember ever commitng something to kscd. Probably I commited 
something FreeDB related 5-10 years ago, but can't remember that.

I can't do a real qualified check of the patch, but from a quick glance it 
doesn't seem to do any harm.

I'll CC to the kdemultimedia mailing list. But if you don't receive any other 
feedback please go on and commit to trunk. It would be nice if you could also 
commit to branch 4.6 after it get unfrozen (which should be abut end of 
January 2011: http://techbase.kde.org/Schedules/KDE4/4.6_Release_Schedule)

Greetings,
     Chrisitan


> Perhaps the case should be handled differently?

No idea. Sorry.

> 
> CCMAIL: esken at kde.org
> 
>  M  +4 -0      kscd.cpp
> 
> 
> --- trunk/KDE/kdemultimedia/kscd/kscd.cpp #1212978:1212979
> @@ -287,8 +287,12 @@
>  	{
> 
>  		title = QString::fromLatin1("%1 - ").arg(currentTrack, 2, 10,
> QLatin1Char('0')) ; +
> +		if (m_MBManager->getTrackList().size() >= (currentTrack))
> +		{
>  		title.append(m_MBManager->getTrackList()[currentTrack-1].Title);
>  		length.append(m_MBManager->getTrackList()[currentTrack-1].Duration);
> +		}
> 
>  		showTrackinfoLabel(title);
>  		m_popup = new TitlePopUp(this, QLatin1String( "popup" ));