Review Request: Fix return value in StreamReader::read

Kamil Klimek naresh at
Mon Feb 21 12:26:38 GMT 2011

This is an automatically generated e-mail. To reply, visit:

Review request for Phonon and Phonon Backends.


length parameter was treated as required size to read. It caused for files with id3v1 tags to end playback at begining of the file, because ret value was treated by libvlc as error. Reading id3v1 tags caused to seek almost to end of file and read not as much data as was put in length parameter. After returning length > 0 (we read at least something) everything started to work fine.


  vlc/streamreader.cpp 89045da 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at

More information about the kde-multimedia mailing list