Review Request: fix audioChannel indexing

Sian Cao yinshuiboy at gmail.com
Wed Aug 24 04:24:45 BST 2011



> On Aug. 23, 2011, 10:38 a.m., Harald Sitter wrote:
> > We really do not understand what this change is supposed to do nor what it is supposed to fix.
> > 
> > It would be very helpful if you could add more details about what is going wrong, how this issue presents itself and why the patch you presented fixes the issue.
> > 
> > (ideally you should do this in a bug report on bugs.kde.org I might add ;))

sorry for the ambiguity, I report a bug (https://bugs.kde.org/show_bug.cgi?id=280681) and describe the situation there.


- Sian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102298/#review5939
-----------------------------------------------------------


On Aug. 23, 2011, 6:33 a.m., Sian Cao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102298/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2011, 6:33 a.m.)
> 
> 
> Review request for KDE Multimedia, Phonon Backends and Harald Sitter.
> 
> 
> Summary
> -------
> 
> libvlc seems have broken id rule, and liblc don't use p_info->i_id as index of audio tracks.
> 
> 
> Diffs
> -----
> 
>   src/mediacontroller.cpp 3aa7b96 
> 
> Diff: http://git.reviewboard.kde.org/r/102298/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110824/5d9ff8e2/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list