Review Request: reset m_hasVideo when some events occurred

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102207/#review5663
-----------------------------------------------------------



src/mediaobject.cpp
<http://git.reviewboard.kde.org/r/102207/#comment5069>

    I am not sure unloading at reset already is that a reliable thing to do, at any rate throwing away the media seems like an unexpected behavior for a function called resetMediaMembers IMHO anyway



src/mediaobject.cpp
<http://git.reviewboard.kde.org/r/102207/#comment5068>

    This seems like unrelated noise for the scope of this review?


- Harald


On Aug. 11, 2011, 6:53 a.m., Sian Cao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102207/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2011, 6:53 a.m.)
> 
> 
> Review request for KDE Multimedia, Phonon Backends and Harald Sitter.
> 
> 
> Summary
> -------
> 
> this fix problem when start to play next source, m_hasVideo is true and MediaObject data won't get resetted.
> 
> 
> Diffs
> -----
> 
>   src/mediaobject.h 3c7be3a 
>   src/mediaobject.cpp 1cc38ab 
> 
> Diff: http://git.reviewboard.kde.org/r/102207/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110812/5e274240/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia