Review Request: visualization: it works

[Harald Sitter]

> On Aug. 10, 2011, 12:02 a.m., Harald Sitter wrote:
> > plenty of full path usage, which is not scalable on linux and particularly not in xplatform context + wrong code style
> 
> Alessandro Siniscalchi wrote:
>     Hi Harald,
>     tell me more about the wrong code style please.

look at the other amarok source files and you'll hopefully notice that you are missing plenty of whitespaces


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102243/#review5558
-----------------------------------------------------------


On Aug. 8, 2011, 1:26 p.m., Alessandro Siniscalchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102243/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2011, 1:26 p.m.)
> 
> 
> Review request for Amarok and Phonon.
> 
> 
> Summary
> -------
> 
> I added two modules to amarok:
> audiodatacenter: it will let all modules that needs raw data to register there. It manages the audioDataOutput path and all the user has not to know.
> 
> audiodataclient: the interface to implement to register to audiodatacenter
> 
> visualM: It starts the projectM-qt project ---> Visualization
> 
> I used the phonon from git repository cause audioDataOutput is fixed in gstreamer backend
> 
> Yeah !!!!!
> 
> 
> TODO: fix a bug in PAth::disconnect. When I disconnect the audioDataOutput ... the audio stops and I have to press play button another time .. I think it deactives the amarok audio path too... I will check
> 
> Screenshot: http://imageshack.us/photo/my-images/190/unledyzl.png/
> 
> 
> Diffs
> -----
> 
>   ChangeLog b086375c963c143a5baf23bd11165302e97ba6e4 
>   src/CMakeLists.txt 00ecacfd242c5c39fce84807620c8a04852d1489 
>   src/EngineController.h ddd8f1b6eef363cebdc596f968f98f5392a5e13c 
>   src/EngineController.cpp 18fbe50732b256e5e051ad08a1b9523d5207dc74 
>   src/MainWindow.h 076628f4b1c12d094b761867c600de2746d076bf 
>   src/MainWindow.cpp 2d2ebacce172fffaaf313294b690424e827b800b 
>   src/audiodatacenter/CMakeLists.txt PRE-CREATION 
>   src/audiodatacenter/audiodatacenter.h PRE-CREATION 
>   src/audiodatacenter/audiodatacenter.cpp PRE-CREATION 
>   src/audiodatacenter/audiodataclient.h PRE-CREATION 
>   src/audiodatacenter/audiodataclient.cpp PRE-CREATION 
>   src/context/CMakeLists.txt 7c210b08c518c5a240d7ce825306de3cfcb2cb21 
>   src/context/applets/albums/CMakeLists.txt 4989f3167807a75168774c8c4bef3faa485ce41b 
>   src/context/applets/currenttrack/CMakeLists.txt ccc1aabf6a0ecca96e89388c990801417862d00c 
>   src/context/applets/info/CMakeLists.txt 8b4aa20b3c3a71fd190f7e9d2067a9d71c9c742b 
>   src/context/applets/labels/CMakeLists.txt 6309d178706396391c8de08dc63ac2433fcbccba 
>   src/context/applets/lyrics/CMakeLists.txt 7ed42066a0d048b6cc9393f33a0aec8d10b1cf09 
>   src/context/applets/photos/CMakeLists.txt ac5eb212170c1bf8c7c2cf04557403078ad1fcab 
>   src/context/applets/videoclip/CMakeLists.txt cfafdf22d69f45bceb7b851d7eba3d24482d5b88 
>   src/context/applets/wikipedia/CMakeLists.txt adb1952eff693fc289506ec5b48776d56fd89f5d 
>   src/core-impl/collections/CMakeLists.txt c78b9202ece71b51189c4e47d85acfa4a74ef8d6 
>   src/core-impl/collections/audiocd/CMakeLists.txt 26f95387f1994e9473c283a1399badb34cb8f566 
>   src/core-impl/collections/db/sql/CMakeLists.txt 0ed51cd13285d10a61f5dc48284f88884fbb0238 
>   src/core-impl/collections/mtpcollection/CMakeLists.txt 581e952f7a35dd3db616fb3e4a4d31b671645128 
>   src/services/opmldirectory/CMakeLists.txt 1ae294c93d54861f5c013a64d8cad62baff52c4c 
>   src/visualm/CMakeLists.txt PRE-CREATION 
>   src/visualm/visualm.h PRE-CREATION 
>   src/visualm/visualm.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102243/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110810/681d7816/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia