kmix patch

[Hugo Pereira Da Costa]

Forwarding to kde-multimedia and Christian, as suggested by Colin.

Since this is a bug/crash fix, it would be very nice if this (or anything 
similar) could go in trunk, before the code is branched in kde4.5
Also, possibly backported for kde4.4
It addresses bug https://bugs.kde.org/show_bug.cgi?id=220621
And there is also a reviewboard (posted to kdelibs) to 
http://reviewboard.kde.org/r/4450/

======================
Hi,

About a week ago I suggested a patch that address bug 220621 (a crash in kmix) 
(see https://bugs.kde.org/show_bug.cgi?id=220621). I'd rather post it on kde 
reviewboard for reviewing, but could not find a relevant group for this. 

Since there's been no comment on this in the bugzilla page, I post it again 
here, attached.
The patch addresses the following issue: 

"_dockAreaPopup->deleteLater()" in  KMixWindow::updateDocking(), leaves the 
"parent" QWidgetAction with a dangling pointer to the widget,
until the action is actually re-created, later on in the code. 

The patch stores and deletes the QWidgetAction directly,
which in turn deletes the widget and has the advantage of not 
leaving any dangling pointer behind, thus preventing (notably) the crash above
triggered by oxygen. 

Comments/advice are welcome.

Hugo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20100624/45eab8f2/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmix.patch
Type: text/x-patch
Size: 2219 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20100624/45eab8f2/attachment.bin>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia