kscd i18n bug, outdated documentation

Burkhard Lück lueck at hube-lueck.de
Thu Jun 18 15:27:06 BST 2009


Am Donnerstag 18 Juni 2009 12:17:11 schrieb Aurélien Gâteau:
>
> Mmm... I had a look at the actual code... it's quite bad actually :/
>
> Anyway it would be a bit nicer to remove the optional arg from the .h
> files. In the .h file, change this:
>
> explicit CloseButton(QWidget * parent=0, const QString& sName="close");
>
> to this:
>
> explicit CloseButton(QWidget * parent=0);
>
> And in the .cpp file, change this:
>
> CloseButton::CloseButton(QWidget * parent,const QString&
> sName):KscdWidget(sName,parent)
>
> to this:
>
> CloseButton::CloseButton(QWidget *
> parent):KscdWidget(I18N_NOOP("close"),parent)
>
> Same for other button classes. The change in kscdwidget.cpp is fine.
>
> This way you do not have to modify Messages.sh.
>
Done that and fixed #186867 with r983601 in trunk.

Thanks for your help.

-- 
Burkhard Lück



More information about the kde-multimedia mailing list