[Patch] Phonon: changing icons for volume and seek sliders

[Tanguy Krotoff]

Hello

"patch that allows to change the default icons for volume and seek
sliders inside Phonon"
The attached picture below is self-explanatory (taken under winxp)

I've submitted this patch a long time ago without replies.

So again, if nobody complains I can commit it using my KDE account tkrotoff...


---------- Forwarded message ----------
From: Tanguy Krotoff <tkrotoff at gmail.com>
Date: Wed, Sep 17, 2008 at 2:59 PM
Subject: [Patch] Phonon: changing icons for volume and seek sliders
To: phonon-backends at kde.org


Hello

Here is a small patch that allows to change the default icons for
volume and seek sliders inside Phonon.
Basically it adds these methods:

void SeekSlider::setIcon(const QIcon &icon)
void VolumeSlider::setVolumeIcon(const QIcon &icon);
void VolumeSlider::setMutedIcon(const QIcon &icon);

I've reworked the patch given Matthias suggestions (that's true that I
didn't really verify it at that time, I think it is OK now)

So if someone could simply tell me if it is OK or not and commit it (I
have a svn account: tkrotoff)

Thanks in advance

On Wed, Jun 4, 2008 at 5:18 PM, Matthias Kretz <kretz at kde.org> wrote:
> The patch is a good idea, but can only go into kdesupport/phonon, not
> branches/phonon/4.2. Calling d->_k_mutedChanged from
> setVolumeIcon/setMutedIcon looks wrong. Even if it does the right thing now,
> you probably better should use it there. Also for
> +    if (d->icon.isNull()) {
> +        d->iconLabel.setVisible(true);
> +    }
> Did you perhaps forget a "!"? Or you meant "setVisible(false)"? Setting a null
> icon should probably just get ignored. To hide the icon there's already a
> dedicated function.
>
> I'm just wondering since when QStyle has SP_MediaVolume(Muted) and why
> Trolltech didn't patch phonon to use those... Also we should check that
> KStyle implements them correctly. Oh, and the dox are wrong then, it should
> say "Default icon used is QStyle::standardIcon(QStyle::SP_MediaVolume)". Too
> bad SP_MediaTime wasn't added...
>
> --
> ________________________________________________________
> Matthias Kretz (Germany)                            <><
> http://Vir.homelinux.org/
> MatthiasKretz at gmx.net, kretz at kde.org,
> Matthias.Kretz at urz.uni-heidelberg.de
>

-- 
Tanguy Krotoff <tkrotoff at gmail.com>
+33 6 68 42 70 24
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sliders_icon.diff
Type: application/octet-stream
Size: 5038 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20090414/b3a5a89b/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sliders_icon.png
Type: image/png
Size: 2084 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20090414/b3a5a89b/attachment.png>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia