Phonon include headers mismatch
kretz at kde.org
Wed Jul 2 15:58:58 BST 2008
On Wednesday 02 July 2008 16:12:21 Thiago Macieira wrote:
> I meant that we should have one *single* include set. Application
> developers shouldn't have to know which version of Phonon was installed.
Yes, breaking the include dirs is a kind of breaking SC.
> I am proposing the Qt-style for the includes:
> #include <Phonon/lowercaseheader.h>
> #include <Phonon/ClassName>
> #include <Phonon/Phonon>
> Note that Phonon 4.1 shipped with Qt does not have that (because of the
> capital P).
> If someone adds -I.../Phonon to their include path, then they can also
> #include <lowercaseheader.h>
> #include <ClassName>
> But they shouldn't do that because the class names are not very unique.
> They have to make sure that the parent directory to Phonon is also there
> because of the internal includes.
> Phonon should now no longer be inside the KDE/ include dir.
Ok, so I'll make 4.2 and trunk install their headers to include/Phonon and
forward headers to the same dir. How do we do the symbolic link? I don't know
of any cmake support for it...
Matthias Kretz (Germany) <><
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
More information about the kde-multimedia