[PATCH] Some UI polish for KMix

[Christian Esken]

Am Mittwoch, 9. Januar 2008 schrieb Aurélien Gâteau:
> Hello,
> 
> I have been working a bit on polishing KMix UI these days. So far I have
> three patches to submit.

Good job. Thanks. :-)

> 
> 0001: When I started KMix for the first time, the volume sliders were 1
> pixel high. This patch sets their minimum height/width (depending on
> orientation) to 150. You can reproduce the bug by removing your kmixrc file
> and starting kmix again.

I knew of this issue. This is the worst KMix issue which I couldn't get resolved. Now I checked it and saw that QSlider has no minimumSize(). So your workaround is basically OK.
But 150 pixels minimum is way too much. 50 would be appropriate.

> 
> 0002: Just a simple change to use sunken line separators instead of raised
> ones. I think they look better.

OK

> 0003: Right now, some extent space is added on slider boundaries to make
> sure sliders without capture or playback options line up with sliders
> featuring these options. This looks odd if none of the visible sliders has
> any capture or playback option (like on the simple soundcard included in my
> laptop). The patch makes sure the extent space is only added when
> necessary.

Good idea.

I checked the patch and found some issues / omissions:
a) it uses setFixedHeight() also for the horizontal case
b) It should also be done for the m_playbackSpacer
c) isVisible() must be replaced by isVisibleTo(), as on startup the code already runs before the widget is visible.

I am reworking this patch: a) is done, c) is done, and I am currently working on b).

> OK to commit?
> 
> Aurélien

As I am currently reworking your patch 0003, it is easier for me, when I will commit the whole thing. OK?

Again: Very nice work. :-)

  Christian