Fwd: Re: [PATCH] Improved Alsa configure-time detection

[Christian Esken]

Rex,

I didn't realize the answer on kde-core-devel wasn't CC'ed on the KDEMM list.
So the answer is a bit late. Sorry for that. Probably you can comment on the 
comment below.

  Christian

----------  Weitergeleitete Nachricht  ----------

Subject: Re: [PATCH] Improved Alsa configure-time detection
Date: Mittwoch, 28. Dezember 2005 01:05
From: Thiago Macieira <thiago at kde.org>
To: kde-core-devel at kde.org

Christian Esken wrote:
>Ah, 	I understand.
>
>As I don't understand much of KDE's build system I am forwarding to
>kde-core-devel - the experirenced people are there.
>
>Can somebody check the attached patches?

Hello Christian,

The patch is ok (in the sense that it doesn't break anything), but it's
redundant.

The setting of CPPFLAGS and LDFLAGS is exactly why we have
KDE_CHECK_{LIB,HEADER}.

So only one of the two changes is necessary. I'd recommend using the
KDE_CHECK_* versions, unless you're nesting the tests one inside the
other.
--
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

2. Tó cennan his weorc gearu, ymbe se circolwyrde, wearð se cægbord and se
leohtspeccabord, and þa mýs cómon lator. On þone dæg, he hine reste.

-------------------------------------------------------