Fix to KSCD are commited(solution)
Alexander Kern
alex.kern at gmx.de
Sun Jun 27 19:04:48 BST 2004
Am Donnerstag, 24. Juni 2004 01:21 schrieb Richard Lärkäng:
> Hi!
>
> Alexander Kern wrote:
> > Hi Aaron,
> >
> > I have fixed all issues about kscd with exception of cdtext problem.
> > It seems, that switch to libcddb was not so good thing. Short, if freedb
> > lookup fails, it does not emit a signal.
> >
> > To List.
> > Hi all, if anybody has a deep knowledge about libccdb, please have a look
> > into...
> >
> > Regards Alex Kern
>
> I think this patch should solve it. Could you try it and either commit
> it yourself or tell me if it works and I'll commit it myself.
>
> Richard Lärkäng
Hi, I found it, why is not working.
Problem place is httplookup.cpp too.
void
HTTPLookup::slotResult( KIO::Job *job )
{
if ( 0 != job->error() )
{
result_ = ServerError;
if ( !block_ ) <---- from you, first error
emit queryReady();
return;
}
QStringList lineList = QStringList::split( "\n", data_ );
QStringList::ConstIterator it = lineList.begin();
switch ( state_ )
{
case WaitingForQueryResponse:
if ( it != lineList.end() )
{
QString line( *it );
result_ = parseQuery( line );
switch ( result_ )
{
case Success:
if ( !block_ )
emit queryReady();
break;
case MultipleRecordFound:
++it;
while ( it != lineList.end() )
{
QString line( *it );
if ( '.' == line[ 0 ] )
{
result_ = Success;
if ( !block_ )
emit queryReady();
break;
}
parseExtraMatch( line );
++it;
}
break;
default:
if ( !block_ ) <--------- from me, second
emit queryReady();
break;
}
}
break;
Would you like to commit? Please drop a mail to me and Release Coordinator.
Thanks Alex
More information about the kde-multimedia
mailing list