[PATCH] mediacontrol - add support for KsCD

Stefan Gehn mETz81 at web.de
Sun Dec 5 18:06:13 GMT 2004


Am Sonntag, 5. Dezember 2004 18:18 schrieb MichaƂ Startek:
> Hello!
> I've written patch that implements support for KsCD in mediacontrol Kicker
> applet from kdeaddons. I hope that this is the correct place to send it (as
> there is no kde-addons mailing list, and kde-multimedia seems to be most
> closely related to this applet). If not, please tell me where I should send
> it.

well, one of my email-adresses would've done it too :)

> Please try to review this patch before commiting, to make sure I've not
> commited some obvious mistakes (though everything seems to work correctly
> here).

Assembling the tracktitle should be done using i18n(). Don't use the + 
operator on user-visible strings, it won't work out for languages written 
from right to left.

Other than that the patch seems to be fine.

Bye, Stefan aka mETz

More information about the kde-multimedia mailing list