Crash in SimplesoundServer

Stefan Westerfeld stefan at space.twc.de
Sat Dec 13 01:52:26 GMT 2003


   Hi!

On Wed, Dec 10, 2003 at 04:22:49PM +0100, Arnold Krille wrote:
> the SimpleSoundServer crashes in the SimpleSoundServer::play() method as it 
> gets a Playobject for the file and doesn't check whether the PlayObject is 
> legal or not. The attached patch fixes this problem.
> 
> Okay to commit?

Looks ok, but it probably should return 0 if it fails to play a file, as
soundserver.idl says:

interface SimpleSoundServer : PlayObjectFactory
{
...
        /**
         * tries to play the sound in "filename"
         *
         * returns an ID when success 0 when it fails
         */
        long play(string filename);
...

   Cu... Stefan
-- 
  -* Stefan Westerfeld, stefan at space.twc.de (PGP!), Hamburg/Germany
     KDE Developer, project infos at http://space.twc.de/~stefan/kde *-         



More information about the kde-multimedia mailing list