[PATCH] KPlayObject fixes for asynchronous generation + patch for kaboodle
Neil Stevens
neil at qualityassistant.com
Sat Aug 31 21:59:18 BST 2002
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Saturday August 31, 2002 06:42, Matthias Welwarsky wrote:
> Even if the implementation is source and binary compatible, some
> caveats:
>
> Don't call KPlayObject.object().isNull() if you want to test for a Null
> Playobject. Kaboodle uses this to find out if loading of the media file
> worked. Call KPlayObject.isNull() instead. It will return "true" if the
> object is a proxy. In general, it should not be necessary to test for
> a Null playobject anyway.
Please document this, if it's dangerous.
> Don't rely on capabilities(), as the proxy object will return "0"
> capabilities if the real object is yet to be created.
How is a user supposed to be able to know whether a playobject is seekable
or pausable then? This is a major regression.
> The proxy object will return Arts::posIdle as state(), even if you just
> called "play". For Streams, it can take an indefinite amount of time
> for the connection to be opened and the playing to start.
This will seriously hurt the usability of apps like kaboodle, and is also a
regression.
All in all, this doesn't seem like a good change to me.
- --
Neil Stevens - neil at qualityassistant.com
"I always cheer up immensely if an attack is particularly wounding
because I think, well, if they attack one personally, it means they
have not a single political argument left." - Margaret Thatcher
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE9cS4mf7mnligQOmERAgJFAJsG+MEszSPrmpX3QcLFcUS2Mkk7IACeOITc
pC4NdQ0UYeoQHHwAxqG78rw=
=SL7B
-----END PGP SIGNATURE-----
More information about the kde-multimedia
mailing list