[valgrind] [Bug 437790] valgrind reports "Conditional jump or move depends on uninitialised value" in memchr of macOS 10.15

[Phil Krylov]

https://bugs.kde.org/show_bug.cgi?id=437790

Phil Krylov <phil.krylov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil.krylov at gmail.com

--- Comment #5 from Phil Krylov <phil.krylov at gmail.com> ---
(In reply to Paul Floyd from comment #4)
> I don't have a 10.15 system to test this with, just an old macbook with
> 10.7.5 and a newer macbook with 12.
> 
> Looking at the code, my guess is that in vg_replace_strmem.c the following
> block
> 
> # if DARWIN_VERS >= DARWIN_10_10
>   MEMCHR(VG_Z_DYLD,                   memchr)
>   /* _platform_memchr$VARIANT$Generic */
>   MEMCHR(libsystemZuplatformZddylib, _platform_memchr$VARIANT$Generic)
>   /* _platform_memchr$VARIANT$Haswell */
>   MEMCHR(libsystemZuplatformZddylib, _platform_memchr$VARIANT$Haswell)
> # endif
> 
> needs to be
> 
> # if DARWIN_VERS >= DARWIN_10_10
>   MEMCHR(VG_Z_DYLD,                   memchr)
>   /* _platform_memchr$VARIANT$Generic */
>   MEMCHR(libsystemZuplatformZddylib, _platform_memchr$VARIANT$Generic)
>   /* _platform_memchr$VARIANT$Haswell */
>   MEMCHR(libsystemZuplatformZddylib, _platform_memchr$VARIANT$Haswell)
> # endif
> #if DARWIN_VERS >= DARWIN_10_14 /* not sure which version */
>   /* _platform_memchr$VARIANT$Base */
>   MEMCHR(libsystemZuplatformZddylib, _platform_memchr$VARIANT$Base)
> #endif
> 
> For the moment I'm just guessing which version added this.
> 
> I can't make this change to the sourceware git repo. The last macos version
> that is officially supported in 10.13.

Hi,

I have the same problem on 10.14 and 10.12. I tested your fix on 10.14 and
10.12, and it works! As 10.12 is affected, is there a chance we can get the fix
merged in?

-- 
You are receiving this mail because:
You are watching all bug changes.