[frameworks-syntax-highlighting] [Bug 468394] r.xml syntax highlighting definitions miss specified integers (e.g., 3L)

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=468394

Christoph Cullmann <cullmann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/syntax-highlighting/
                   |                            |-/commit/ef856a14e35194f0ee
                   |                            |532326dfa5042adbeea251
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Christoph Cullmann <cullmann at kde.org> ---
Git commit ef856a14e35194f0ee532326dfa5042adbeea251 by Christoph Cullmann, on
behalf of Jonathan Poelen.
Committed on 15/07/2023 at 19:26.
Pushed by cullmann into branch 'master'.

R: add numeric suffix (i and L)

It doesn't seem to be a bug on our side, but I did make one change:
highlighting suffixes.

I wonder if we shouldn't generalize and standardize this? There are several
behaviors depending on the syntax:

There are several behaviors depending on the syntax:

- no treatment for suffixes, they often (always?) have the Normal color
- number and suffix have the same color, but the color of the same suffix can
vary between Float, Int, Hex, etc.
- suffixes have a dedicated color

As shown in this commit, I'm in favor of the dedicated color and propose to
generalize it to all syntaxes, what do you think?

M  +3    -0    autotests/folding/highlight.R.fold
M  +3    -0    autotests/html/highlight.R.dark.html
M  +3    -0    autotests/html/highlight.R.html
M  +3    -0    autotests/input/highlight.R
M  +3    -0    autotests/reference/highlight.R.ref
M  +7    -2    data/syntax/r.xml

https://invent.kde.org/frameworks/syntax-highlighting/-/commit/ef856a14e35194f0ee532326dfa5042adbeea251

-- 
You are receiving this mail because:
You are watching all bug changes.