[digikam] [Bug 439241] DigiKam - Feature request - Working with 'Tags'

[David Haslam]

https://bugs.kde.org/show_bug.cgi?id=439241

David Haslam <dch.code at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dch.code at gmail.com

--- Comment #3 from David Haslam <dch.code at gmail.com> ---
I've been looking into issue number 3:

  3. Could the 'highlight' colour in the Search box be modified so
     that the 'Delete' button '<X' is not obscured by the highlight
     colour?

And it seems that the red and green colors are hardcoded, and don't
take into account dark colour schemes.

So I've been working on a patch to make the SearchTextBar widget
adjust the colors for dark modes. Ideally the colours should come from
the loaded colour scheme file so the user can tweak them, but that's
not straightforward at the moment due to the way colour scheme
handling is implemented.

For now, I'm experimenting with detecting dark/light color schemes but
hardcoding these colors:

Breeze (light)
View/NegativeBackground   55, 27, 37     dark red
View/PositiveBackground   26, 52, 26     dark green

Breeze Dark
View/NegativeBackground   249, 233, 234  light red
View/PositiveBackground   212, 250, 226  light green

I've attached a montage of screen grabs illustrating how this looks
with various color schemes.

These are on Linux with Breeze icon theme. Sorry, I don't have access
to a Mac to see what that looks like.

Notice also that the delete icon is now clearly visible in all schemes.

Any thoughts before I continue and submit a merge request?

David

-- 
You are receiving this mail because:
You are watching all bug changes.