[extra-cmake-modules] [Bug 444247] New: CheckAtomic doesn't set LLVM_COMPILER_IS_GCC_COMPATIBLE and fails check on Apple Clang

[amyspark]

https://bugs.kde.org/show_bug.cgi?id=444247

            Bug ID: 444247
           Summary: CheckAtomic doesn't set
                    LLVM_COMPILER_IS_GCC_COMPATIBLE and fails check on
                    Apple Clang
           Product: extra-cmake-modules
           Version: 5.87.0
          Platform: Compiled Sources
                OS: macOS
            Status: REPORTED
          Severity: major
          Priority: NOR
         Component: general
          Assignee: ecm-bugs-null at kde.org
          Reporter: amy at amyspark.me
  Target Milestone: ---

SUMMARY

When CheckAtomic was updated to the upstream version, the author missed that
LLVM_COMPILER_IS_GCC_COMPATIBLE is a check set by another LLVM module,
DetermineGCCCompatible. This module isn't anywhere in ECM, so the check fails.
This is needed especially on Apple Clang, because `-latomic` doesn't exist
there.

STEPS TO REPRODUCE
1. On a macOS platform, include(CheckAtomic) and try linking an executable.

OBSERVED RESULT
https://binary-factory.kde.org/job/Krita_Nightly_MacOS_Build/919/consoleText

> [2021-10-22T07:15:21.063Z] ld: library not found for -latomic

EXPECTED RESULT

Executables using `std::atomic` work successfully.


SOFTWARE/OS VERSIONS
Windows: 
macOS: See the ARM runner in binary factory.
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Cherry-pick
https://invent.kde.org/graphics/krita/-/commit/8e7ccd3cd7601ac4c27696eafd8cd1bb8a40296c
to fix this.

-- 
You are receiving this mail because:
You are watching all bug changes.