D22460: DrKonqi: improved lldb integration

René J.V. Bertin noreply at phabricator.kde.org
Sun Jul 14 22:09:48 BST 2019


rjvbb created this revision.
rjvbb added reviewers: kde-frameworks-devel, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rjvbb requested review of this revision.

REVISION SUMMARY
  Since a few versions lldb has had a tendency to remain stuck after the initial connection to the crashed application (on Mac). On Linux it would often exit cleanly and quickly in a way not foreseen by my previous code, causing DrKonqi to report an unexpected debugger termination.
  
  This patch addresses both issues:
  
  - recent lldb versions have no more problems with reading commands from a batchfile
  - this make it possible to add an explicit exit command
  - `slotProcessExited()` is called explicitly when lldb has confirmed the exit command
  - errors caused by terminating or killing the debugger process are now ignored.

TEST PLAN
  Getting a crash backtrace now works as expected on Mac and Linux. No regressions are introduced when using the gdb backend on Linux.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22460

AFFECTED FILES
  src/backtracegenerator.cpp
  src/backtracegenerator.h
  src/data/debuggers/internal/lldbrc

To: rjvbb, kde-frameworks-devel, #plasma
Cc: plasma-devel, kde-mac, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20190714/1a0157b8/attachment.html>


More information about the kde-mac mailing list