D5990: Ark: Mac UI adaptations
noreply at phabricator.kde.org
Mon May 29 09:28:23 UTC 2017
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
> The event handler class instance is declared volatile to decrease the chance that the linker will optimise the assignment away because the variable isn't used. Maybe wouldn't happen anyway when using new to initialise a local variable?
Correct, see https://stackoverflow.com/questions/27741698/is-c-compiler-allowed-to-optimize-out-unreferenced-local-objects
So please remove the `volatile`.
In fact, the `new Foo();` pattern is quite common in Qt code, e.g. for dbus adaptor one would just do `new MyAdaptor(this);`.
To: rjvbb, #ark, #kde_applications, elvisangelaccio
Cc: elvisangelaccio, kde-utils-devel, kde-mac, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-mac