D5990: Ark: Mac adaptations
René J.V. Bertin
noreply at phabricator.kde.org
Sun May 28 13:17:13 UTC 2017
rjvbb updated this revision to Diff 14915.
rjvbb added a comment.
The kerfuffle changes (lowlevel) were moved to their own revision, making this a patch that affects the user experience directly.
The #ifdefs were all removed, since the additional code should not have any effect elsewhere but on Mac (QFileOpenEvent might in the future be supported elsewhere too, btw).
The event handler class instance is declared volatile to decrease the chance that the linker will optimise the assignment away because the variable isn't used. Maybe wouldn't happen anyway when using `new` to initialise a local variable?
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5990?vs=14891&id=14915
REVISION DETAIL
https://phabricator.kde.org/D5990
AFFECTED FILES
app/CMakeLists.txt
app/MacOSXBundleInfo.plist.in
app/main.cpp
To: rjvbb, #ark, #kde_applications
Cc: elvisangelaccio, kde-utils-devel, kde-mac, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20170528/a3f064bf/attachment.html>
More information about the kde-mac
mailing list