D5990: Ark: Mac adaptations
René J.V. Bertin
noreply at phabricator.kde.org
Sat May 27 21:39:19 UTC 2017
rjvbb added a comment.
In https://phabricator.kde.org/D5990#112204, @elvisangelaccio wrote:
> Could you please split the patch into self-contained commits? (it would be easier to review the changes)
You want separate review requests?
>> Ideally the toplevel CMake file should check the clang version being used; the build fails for me with AppleClang 600 (= clang 3.5).
> What's the error? Can't we just fix it?
There's an error about `return QString();` from the lambda in the kerfuffle plugin which can be fixed with a cast, but there are other issues which I think stem from incomplete C++11 support.
To: rjvbb, #ark, #kde_applications
Cc: elvisangelaccio, kde-utils-devel, kde-mac, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-mac