D4929: DrKonqi : lldb support

[René J.V. Bertin]

rjvbb marked 8 inline comments as done.
rjvbb added inline comments.

INLINE COMMENTS

> kfunk wrote in backtracegenerator.cpp:62
> Please do this only if `lldb` is used then. No need  to change code which apparently worked fine for years. Also, did you try `QProcess::terminate` instead?
> 
> PS: `QProcess` gets unhappy when being deleted while still running (=> runtime warnings).
> 
> PPS: Please read my other advice about quitting LLDB below, too

Re (sic:) KProcess::terminate(): see the hunk around line 145!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: kfunk, mart, broulik, kde-mac, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20170310/ce0a5fcb/attachment.html>