Review Request 129778: proposal: make use of KDE file dialogs depend on a build option

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129778/
-----------------------------------------------------------

(Updated Jan. 5, 2017, 3:18 p.m.)


Review request for KDE Software on Mac OS X and KDevelop Valgrind Plugin.


Repository: kdevplatform


Description (updated)
-------

As discussed on the kdevelop-devel ML ("KDE vs. native/Qt file dialogs"):

This patch introduces a build (CMake) option that allows chosing between the use of KDE or platform-native file dialogs, currently in places where the choice isn't determine by the platform theme or theme plugin. The option defaults to OFF on MSWin and Mac, ON everywhere else (that should catch everything Unix/X11 or Wayland).


Diffs
-----

  CMakeLists.txt d8b4e4f 
  shell/documentcontroller.cpp 203ae2a 
  shell/openprojectdialog.cpp 84965e3 

Diff: https://git.reviewboard.kde.org/r/129778/diff/


Testing
-------

Works as intended for the file dialogs currently under KDE_FULL_SESSION control in KDevPlatform. The principle could probably be extended to other file dialogs and a flag may need to be set somewhere if this KDevPlatform build setting should apply also to building KDevelop (suggestions and participation welcome).


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20170105/1b5e7678/attachment.html>