D9289: KCompletionBox: restore proper layering behaviour on Mac

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kcompletionbox.cpp:68
>      q->setAttribute(Qt::WA_ShowWithoutActivating);
> -    q->setWindowFlags(Qt::Window | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint); // calls setVisible, so must be done after initializations
> +    q->setWindowFlags(Qt::Dialog | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint); // calls setVisible, so must be done after initializations
>      q->setUniformItemSizes(true);

This looks wrong to me, it's not a dialog. Can you try

  q->setWindowFlags(q->windowFlags() | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint);

or Qt::Popup | ...
When you test with open completion box minimize or switch window (alt+tab) should dismiss it.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9289

To: rjvbb, #frameworks
Cc: anthonyfieroni, kde-mac
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20171215/3fe15b3a/attachment.html>