Review Request 129289: small tweaks for building on Mac

René J.V. Bertin rjvbertin at gmail.com
Sun Oct 30 17:06:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129289/
-----------------------------------------------------------

Review request for KDE Software on Mac OS X and Skrooge.


Repository: skrooge


Description
-------

This patch provides a few small tweaks to improve the Mac build:

- build skroogeconvert as a regular ("nongui") executable instead of an app bundle
- generate a multi-scale icon from all png icons size 256px and smaller
- prevent runtime discarding of the app icon if icon-from-theme lookup doesn't work (which it doesn't by default on OS X)


Diffs
-----

  skrooge/CMakeLists.txt 03bc220 
  skrooge/main.cpp c49fec7 
  skroogeconvert/CMakeLists.txt 28b4901 

Diff: https://git.reviewboard.kde.org/r/129289/diff/


Testing
-------

Works as intended on OS X 10.9.5 with Qt 5.6.1 and KF5 5.27.0


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20161030/410cc438/attachment.html>


More information about the kde-mac mailing list