Review Request 129363: reliability fixes

[Marko Käning]

> On Nov. 28, 2016, 6:19 p.m., Yichao Yu wrote:
> > Ship It!

René, will you ship this?


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129363/#review101161
-----------------------------------------------------------


On Nov. 8, 2016, 7:56 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129363/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 7:56 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Yichao Yu.
> 
> 
> Repository: qtcurve
> 
> 
> Description
> -------
> 
> I've been making a number of fixes to QtCurve recently, mostly to improve the reliability of its settings management. The current set of fixes is getting a bit complex and thus something I'd rather put up for review while I work on it.
> 
> The leitmotiv is: read and write all settings all the time, even if you don't use everything. This prevents settings getting lost.
> 
> This approach is all the more important since I've restored the support for a system-wide stylerc file. For now that's a MacPorts patch, but I'd be happy to include it here if it's considered of general use.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   qt4/common/config_file.cpp 7a0a6bc 
>   qt4/config/qtcurveconfig.cpp 740150f 
>   qt4/style/qtcurve.cpp 5447e07 
>   qt5/common/config_file.cpp 7630f4e 
>   qt5/config/qtcurveconfig.cpp df8ce89 
>   qt5/style/qtcurve.cpp 4457def 
> 
> Diff: https://git.reviewboard.kde.org/r/129363/diff/
> 
> 
> Testing
> -------
> 
> Being tested on Mac and Linux with QtCurve the main style.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20161129/668eb9db/attachment-0001.html>