Review Request 129511: use QSettings::IniFormat everywhere

[René J.V. Bertin]

> On Nov. 20, 2016, 9:33 p.m., Kåre Särs wrote:
> > I think that the decision to go for "ini-format-always" is up to the Sonnet guys, and then we have to adapt here accordingly. We just read the global setting here and it has to be the same as Sonnet is using otherwise we only get the default value. 
> > 
> > The settings handling in Sonnet is not optimal. The applications can not have their own private Sonnet settings it is always global :(
> > 
> > At one point I was planning to create a patch to expose the Sonnet setting object so that an application could set it's own private settings, but I never came around to doing it...
> 
> René J.V. Bertin wrote:
>     This point already came up in the related Sonnet RR (https://git.reviewboard.kde.org/r/127635/).
>     
>     I'm not having much luck until now finding references to the discussion on the ML or to RRs (but one can only search on title here, correct?)
> 
> Kåre Särs wrote:
>     A migrating option could be to use QSettings::allKeys() to see if the "ini settings" contains any data and if not read/write the platform standard version on windows and mac. Removing the "old" setting is probably not good when the setting is global... it could have a settings clearing effect on older apps :)
> 
> René J.V. Bertin wrote:
>     Eh? The proposition was *not* to use the platform standard version (QSettings::NativeFormat). But yes, in order to do things really properly one would need some form of migration (import using the old format, import using the IniFormat, write as IniFormat).
> 
> Kåre Särs wrote:
>     Yes, only if the new default IniFormat is _empty_, would we check the NativeFormat. And use IniFormat after that.

Fine with me, but that does assume that people don't run applications built against the old and the new format, doesn't it?

FWIW, I notice that KWallet5 migrates my KDE4 wallet each time the latter has changed, which happens on a regular basis as I'm still using a KDE4 desktop.

Anyway, this is a lesser concern here, an the per-application aspect could be as well. It is very likely that applications do not share the same ConfigLocation and/or DataLocation paths on systems where they are built to ship each with their own copy of all required frameworks.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129511/#review100980
-----------------------------------------------------------


On Nov. 20, 2016, 9:10 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129511/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2016, 9:10 p.m.)
> 
> 
> Review request for Kate, KDE Software on Mac OS X and Kåre Särs.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> A while back already there was a consensus on the frameworks-devel ML (backed by a few related RRs) that it was best to standardise on the `QSettings::IniFormat` to reduce the number of unnecessary platform differences, and to avoid storing settings in the registry on MS Windows.
> 
> I've been running KTextEditor with this patch for almost a year; somehow I forgot to submit it for review until now.
> 
> 
> Diffs
> -----
> 
>   src/utils/kateconfig.cpp 30dd4fe 
> 
> Diff: https://git.reviewboard.kde.org/r/129511/diff/
> 
> 
> Testing
> -------
> 
> Tested since December 2015 on OS X 10.9.5 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20161121/c35eb818/attachment-0001.html>