Review Request 129511: use QSettings::IniFormat everywhere

[René J.V. Bertin]

> On Nov. 20, 2016, 9:11 p.m., Dominik Haumann wrote:
> > What's unclear from this review request is what bug does it address?
> > If there was such a discussion on the mailing list, is there a link to it?

Yeah, I imagine that it comes a bit out of the blue, about a year after this was discussed for other frameworks. Evidently I didn't keep references, but I should be able to find traces of the other RRs or else hopefully a commit or two.

This doesn't address a bug in the strict sense. It addresses an omission which lets Qt use whatever default format it decided to use for a given platform. This means that documentation cannot describe a single, standard format where describing the content and layout of settings files is justified. It also means that settings are stored in the Windows Registry on MS Windows (unless Qt decides to change that), and possibly in binary plists (for which Apple no longer provides a standalone editor) on Mac.

I'd think that using the Ini format everywhere also means that code manipulating settings files is more guaranteed to work as intended everywhere if it works on Linux where that format is "native".


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129511/#review100977
-----------------------------------------------------------


On Nov. 20, 2016, 9:10 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129511/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2016, 9:10 p.m.)
> 
> 
> Review request for Kate, KDE Software on Mac OS X and Kåre Särs.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> A while back already there was a consensus on the frameworks-devel ML (backed by a few related RRs) that it was best to standardise on the `QSettings::IniFormat` to reduce the number of unnecessary platform differences, and to avoid storing settings in the registry on MS Windows.
> 
> I've been running KTextEditor with this patch for almost a year; somehow I forgot to submit it for review until now.
> 
> 
> Diffs
> -----
> 
>   src/utils/kateconfig.cpp 30dd4fe 
> 
> Diff: https://git.reviewboard.kde.org/r/129511/diff/
> 
> 
> Testing
> -------
> 
> Tested since December 2015 on OS X 10.9.5 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20161120/fb6ea9be/attachment.html>