[KDE/Mac] Review Request 128004: fix alignment issue with the OS X native "macintosh" style

[René J.V. Bertin]

> On May 24, 2016, 6:03 p.m., Elvis Angelaccio wrote:
> > Shouldn't this be fixed in Qt? Or is KCalc the only application exposing the bug?
> > 
> > Anyway, this doesn't break the KCalc layout on Linux, so it seems safe.

I'm not sure if it's actually a bug in Qt. It could also be a border case where you end up in a situation where Qt doesn't use QMacStyle but QStyle instead (kudos for Christoph Feck for figuring that out, a few years back already).
I presume that `Qt::WA_LayoutUsesWidgetRect` is the default with any other widget style than `"macintosh"`.

Until now KCalc is the only application in which a fix is required in application code, but I've just submitted 2 other RR's for occurrences in KIO and KWidgetsAddons that led to comparable glitches (less impressing, though). And there are still at least 1 or 2 other widgets that need fixing, but of which I haven't yet identified the exact class.

What's certain is that we have never seen this kind of issue with "pure Qt5" applications, only in KDE. That makes me hesitate to file a Qt bug report; they might simply consider this something that "you shouldn't do or else you just set Qt::WA_LayoutUsesWidgetRect". They don't go out of their way to ensure that each and every widget feature works the same way on all supported platforms (cf `QMenu::addTitle()`).


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128004/#review95746
-----------------------------------------------------------


On May 24, 2016, 5:32 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128004/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 5:32 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Utils, Christoph Feck, and Elvis Angelaccio.
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> This fixes the alignment issue discussed at
> https://bugs.kde.org/show_bug.cgi?id=339670
> 
> 
> Diffs
> -----
> 
>   kcalc_button.cpp 47227c9 
> 
> Diff: https://git.reviewboard.kde.org/r/128004/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with KF5 frameworks 5.20.0, Qt 5.6.0 and KCalc 16.4.1 .
> 
> 
> File Attachments
> ----------------
> 
> kcalc using the native "macintosh" platform theme
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/087a7849-d593-45e6-886f-bdae9736b4c0__Screen_Shot_2016-05-24_at_17.23.14.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160524/ba11652f/attachment.html>