[KDE/Mac] Review Request 127932: [OS X] open documents from Finder (= through LaunchServices) and preserve app icon

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127932/
-----------------------------------------------------------

(Updated May 24, 2016, 5:10 p.m.)


Review request for Gwenview and KDE Software on Mac OS X.


Changes
-------

fixed the 2 minor issues.


Repository: gwenview


Description
-------

This patch takes care of 2 things on OS X:
- it prevents the application icon (installed via `ecm_add_app_icon`) to be replaced by an empty icon in main (`QApplication::setWindowIcon(QIcon::fromTheme(QStringLiteral("gwenview")))`)
- it installs an extended `Info.plist` and an event filter that catches `QFileOpenEvent`s so that gwenview can open documents served through LaunchServices, e.g. when using the Finder's "Open With" function. This same code should also work under MS Windows.


Diffs (updated)
-----

  app/CMakeLists.txt dcf486f 
  app/main.cpp f9c87c3 
  app/mainwindow.h 6d252f9 
  app/mainwindow.cpp 7b30c4e 

Diff: https://git.reviewboard.kde.org/r/127932/diff/


Testing
-------

With OS X 10.9.5, Qt 5.6.0 and K5FWs 5.20.0 . It currently doesn't attempt to queue incoming requests in some sort of temporal buffer so that it can open groups of documents.


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160524/c6367a12/attachment.html>