[KDE/Mac] Review Request 127896: make dbus optional on osx: kauth

Nick Shaforostoff shafff at ukr.net
Fri May 20 21:13:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127896/
-----------------------------------------------------------

(Updated May 20, 2016, 9:13 p.m.)


Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and Martin Gräßlin.


Changes
-------

made dbus enabling/disabling be available via cmake config option only, as asked


Repository: kauth


Description
-------

this is the first patch to make kde frameworks build (and then work) without dbus.

this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a common service in osx world, kde apps on osx should use native means for interprocess communication instead -- this will make them better citizens in osx ecosystem.


Diffs (updated)
-----

  CMakeLists.txt 48dc2d9 
  autotests/BackendsManager.cpp 59675b3 
  autotests/CMakeLists.txt b53d760 
  autotests/HelperTest.cpp 8050a06 
  src/CMakeLists.txt 1b6930d 
  src/ConfigureChecks.cmake d46761a 

Diff: https://git.reviewboard.kde.org/r/127896/diff/


Testing
-------

compiles fine on osx, compiles fine on linux, tests on linux still pass.


Thanks,

Nick Shaforostoff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160520/470c54b7/attachment.html>


More information about the kde-mac mailing list