[KDE/Mac] Review Request 128272: support -iframework and -F header search path options
René J.V. Bertin
rjvbertin at gmail.com
Sat Jun 25 10:19:52 UTC 2016
> On June 22, 2016, 10:38 p.m., Milian Wolff wrote:
> > ok, but you are still missing the defines/includes manager changes as well as forwarding the required stuff from the project manager interfaces
>
> René J.V. Bertin wrote:
> slowly getting there ... what we have here and now was the trivial part...
>
> For now I hope that I can do with adding only frameworkDirs() and frameworkDirsInBackground() methods to IDefinesAndIncludesManager::Provider and IDefinesAndIncludesManager::backgroundProvider().
>
> BTW it looks like the QMake manager doesn't use the MakeFileResolver at all? It also appears that I'll need to add a `frameworkDirectories()` method to IBuildSystemManager (which is in kdevplatform), is that correct?
>
> Milian Wolff wrote:
> yes, correct.
>
> René J.V. Bertin wrote:
> The change is simple enough, but how do I add a patch for a KDevPlatform file to this ticket? As an attachment?
>
> Milian Wolff wrote:
> you create a separate review request for that
>
> René J.V. Bertin wrote:
> Right, I feared so. Not very practical but what can you do...
https://git.reviewboard.kde.org/r/128284/
I'd love to see that get applied ASAP but that would require providing a default implementation for `IBuildSystemManager::frameworkDirectories()`.
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128272/#review96800
-----------------------------------------------------------
On June 23, 2016, 12:56 a.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128272/
> -----------------------------------------------------------
>
> (Updated June 23, 2016, 12:56 a.m.)
>
>
> Review request for KDE Software on Mac OS X and KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> This is a draft implementation for parser support of the `-iframework dir` and `-F dir` compiler arguments. On OS X these are the framework equivalents of `-isystem` and `-I` respectively, telling the compiler and/or linker where to find framework bundles.
>
> I started out making the new code available on OS X only but that introduces a lot of #ifdefs for probably little benefit. On the contrary, clang supports the arguments on Linux too, presumably because clang is a functional cross-compiler that can generate Darwin Mach-O object files on Linux too.
>
> For the 1st approach I propose to parse the framework directories, adding the effective header directories of the individual frameworks as if they were added explicitly. The framework directories are also added to a new list in the result structure. I presume that this is a prerequisite for adding them to the (lib)clang arguments of the clang parser.
>
>
> Diffs
> -----
>
> languages/plugins/custom-definesandincludes/CMakeLists.txt 5a6c5b7
> languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.h 7a5184f
> languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp 24e532a
> languages/plugins/custom-definesandincludes/idefinesandincludesmanager.h 5da71f2
> projectmanagers/cmake/cmakeimportjsonjob.cpp f064647
> projectmanagers/cmake/cmakemanager.h 3096b7d
> projectmanagers/cmake/cmakemanager.cpp 5c15e2f
> projectmanagers/cmake/cmakeprojectdata.h 60e8773
> projectmanagers/custom-buildsystem/custombuildsystemplugin.h 372b283
> projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp b04647e
> projectmanagers/custommake/custommakemanager.h 33c2997
> projectmanagers/custommake/custommakemanager.cpp e2ce943
> projectmanagers/custommake/makefileresolver/makefileresolver.h 22f9dba
> projectmanagers/custommake/makefileresolver/makefileresolver.cpp ab069bb
> projectmanagers/custommake/makefileresolver/tests/test_custommake.h 3ad0f36
> projectmanagers/custommake/makefileresolver/tests/test_custommake.cpp 368e83e
> projectmanagers/qmake/qmakemanager.h e5e3266
> projectmanagers/qmake/qmakemanager.cpp 123b474
>
> Diff: https://git.reviewboard.kde.org/r/128272/diff/
>
>
> Testing
> -------
>
> the unittest works as expected on OS X.
>
>
> File Attachments
> ----------------
>
> the real companion patch for kdevplatform
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/22/67189f62-ec2c-4797-a315-cafc44fbbb6d__patch-support-kdevp-frameworks.diff
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20160625/27949224/attachment.html>
More information about the kde-mac
mailing list